From cc59b5cf66255f4ee86512624717c52a10b55784 Mon Sep 17 00:00:00 2001
From: Julian Sagebiel <julian.sagebiel@idiv.de>
Date: Sat, 21 Dec 2024 19:25:48 +0100
Subject: [PATCH] small changes and test added

---
 R/readdesign.R                   |  4 ++--
 tests/testthat/test-readdesign.R | 14 ++++++++++++++
 2 files changed, 16 insertions(+), 2 deletions(-)

diff --git a/R/readdesign.R b/R/readdesign.R
index 42804a6..0545dc4 100644
--- a/R/readdesign.R
+++ b/R/readdesign.R
@@ -75,10 +75,10 @@ as.data.frame(designf)
         # Extract alt as the alternative identifier
         alt = sub(".*\\.", "", row_id)
       ) %>%
-      dplyr::select(-row_id) %>% # Drop the original row_id
+      dplyr::select(-"row_id") %>% # Drop the original row_id
       tidyr::pivot_wider(
         id_cols = "Choice.situation",          # Group by Choice.situation
-        names_from = alt,                # Use alt to create column suffixes
+        names_from = "alt",                # Use alt to create column suffixes
         values_from = -c("Choice.situation", "alt"), # Values from other columns
         names_glue = "{alt}.{.value}"          # Custom naming convention
       )
diff --git a/tests/testthat/test-readdesign.R b/tests/testthat/test-readdesign.R
index d1bd504..8c6734b 100644
--- a/tests/testthat/test-readdesign.R
+++ b/tests/testthat/test-readdesign.R
@@ -84,3 +84,17 @@ design_path <- system.file("extdata","ValuGaps", "des1.RDS" ,package = "simulate
 test_that("all is correct with full spdesign objects", {
   expect_no_error(readdesign(design = design_path, designtype = "spdesign"))
 })
+
+
+
+### Tests for idefix
+
+design_idefix <- system.file("extdata","Idefix_designs", "test_design2.RDS" ,package = "simulateDCE")
+
+
+
+test_that("all is correct with full idefix objects", {
+  expect_no_error(readdesign(design_idefix, designtype = "idefix"))
+})
+
+
-- 
GitLab