diff --git a/basics.html b/basics.html index 31749aa60498ef87a85a493e4287a1706307affa..d0cdb352a0b60edc9b6b556fca931953b2d566b5 100644 --- a/basics.html +++ b/basics.html @@ -917,7 +917,24 @@ - we: review one MR, show line comments in GL, thumbs up </section> - <section id="collab-review-coc" data-markdown> + <section id="collab-review-criticism" data-markdown> + ## criticism / commenting + + - **positive**: leave a star, blog about it + - **negative/destructive**: keep it to yourself! + - **constructive**: issues and merge requests! + - check if already reported + - emote if you agree + - discuss if you disagree + + notes: + - issues / requests are supposed to be technical + - avoid **#metwo**, this is annoying for maintainers, use emotes + - rule: comment only if you have something new to add to the + discussion + </section> + + <section id="collab-review-code-of-conduct" data-markdown> ## review ### code of conduct @@ -928,7 +945,8 @@ notes: - the discussions are usually public, so be aware of that - - decide with your team, write `CONTRIBUTING.md` + - usually needed when community grows + - decide with your community, write `CONTRIBUTING.md` </section> <section id="collab-review-your-turn" data-markdown>