From a435dd24a2bf8f85c1a8950112a77ab215fdca6f Mon Sep 17 00:00:00 2001
From: Christian Krause <christian.krause@idiv.de>
Date: Mon, 3 Dec 2018 14:39:53 +0100
Subject: [PATCH] adds criticism and commenting rulez
---
basics.html | 22 ++++++++++++++++++++--
1 file changed, 20 insertions(+), 2 deletions(-)
diff --git a/basics.html b/basics.html
index 31749aa..d0cdb35 100644
--- a/basics.html
+++ b/basics.html
@@ -917,7 +917,24 @@
- we: review one MR, show line comments in GL, thumbs up
</section>
- <section id="collab-review-coc" data-markdown>
+ <section id="collab-review-criticism" data-markdown>
+ ## criticism / commenting
+
+ - **positive**: leave a star, blog about it
+ - **negative/destructive**: keep it to yourself!
+ - **constructive**: issues and merge requests!
+ - check if already reported
+ - emote if you agree
+ - discuss if you disagree
+
+ notes:
+ - issues / requests are supposed to be technical
+ - avoid **#metwo**, this is annoying for maintainers, use emotes
+ - rule: comment only if you have something new to add to the
+ discussion
+ </section>
+
+ <section id="collab-review-code-of-conduct" data-markdown>
## review
### code of conduct
@@ -928,7 +945,8 @@
notes:
- the discussions are usually public, so be aware of that
- - decide with your team, write `CONTRIBUTING.md`
+ - usually needed when community grows
+ - decide with your community, write `CONTRIBUTING.md`
</section>
<section id="collab-review-your-turn" data-markdown>
--
GitLab