Skip to content
GitLab
Explore
Sign in
Primary navigation
Search or go to…
Project
git-seminar
Manage
Activity
Members
Labels
Plan
Issues
Issue boards
Milestones
Wiki
Requirements
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Snippets
Locked files
Deploy
Releases
Package registry
Model registry
Operate
Terraform modules
Monitor
Incidents
Analyze
Value stream analytics
Contributor analytics
Repository analytics
Code review analytics
Issue analytics
Insights
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
Maximilian Konzack
git-seminar
Commits
c54b3a88
Verified
Commit
c54b3a88
authored
6 years ago
by
ck85nori
Browse files
Options
Downloads
Patches
Plain Diff
splits review in two sections
code of conduct, your turn
parent
24a59e89
Branches
Branches containing commit
No related tags found
No related merge requests found
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
basics.html
+18
-8
18 additions, 8 deletions
basics.html
with
18 additions
and
8 deletions
basics.html
+
18
−
8
View file @
c54b3a88
...
@@ -920,17 +920,27 @@
...
@@ -920,17 +920,27 @@
- we: review one MR, show line comments in GL, thumbs up
- we: review one MR, show line comments in GL, thumbs up
</section>
</section>
<section
id=
"collab-review"
data-markdown
>
<section
id=
"collab-review
-coc
"
data-markdown
>
## review
## review
### code of conduct
code of conduct:
1. be friendly
1. be responsible
1. be open
1. be proactive
- be friendly
notes:
- be responsible
- the discussions are usually public, so be aware of that
- be open
- decide with your team, write `CONTRIBUTING.md`
- be creative
</section>
- be proactive
- have fun
<section
id=
"collab-review-your-turn"
data-markdown
>
## review
### your turn
1. review a merge request
1. discuss / emote
1. comment on code
</section>
</section>
<section
id=
"collab-conflicts"
data-markdown
>
<section
id=
"collab-conflicts"
data-markdown
>
...
...
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment