Skip to content
Snippets Groups Projects
Verified Commit a435dd24 authored by ck85nori's avatar ck85nori :railway_track:
Browse files

adds criticism and commenting rulez

parent 51db1fd7
Branches
No related tags found
No related merge requests found
...@@ -917,7 +917,24 @@ ...@@ -917,7 +917,24 @@
- we: review one MR, show line comments in GL, thumbs up - we: review one MR, show line comments in GL, thumbs up
</section> </section>
<section id="collab-review-coc" data-markdown> <section id="collab-review-criticism" data-markdown>
## criticism / commenting
- **positive**: leave a star, blog about it
- **negative/destructive**: keep it to yourself!
- **constructive**: issues and merge requests!
- check if already reported
- emote if you agree
- discuss if you disagree
notes:
- issues / requests are supposed to be technical
- avoid **#metwo**, this is annoying for maintainers, use emotes
- rule: comment only if you have something new to add to the
discussion
</section>
<section id="collab-review-code-of-conduct" data-markdown>
## review ## review
### code of conduct ### code of conduct
...@@ -928,7 +945,8 @@ ...@@ -928,7 +945,8 @@
notes: notes:
- the discussions are usually public, so be aware of that - the discussions are usually public, so be aware of that
- decide with your team, write `CONTRIBUTING.md` - usually needed when community grows
- decide with your community, write `CONTRIBUTING.md`
</section> </section>
<section id="collab-review-your-turn" data-markdown> <section id="collab-review-your-turn" data-markdown>
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment